From 6215ca4625b5e4dbee99113ec10eff1c8f59bb8d Mon Sep 17 00:00:00 2001 From: Denis <18046412+gshadows@users.noreply.github.com> Date: Sun, 15 Jul 2018 18:47:24 +0300 Subject: [PATCH] Make "share" button more meaningful: share an article title. --- .../com/example/xyzreader/ui/ArticleDetailActivity.java | 9 ++++++--- XYZReader/src/main/res/values/strings.xml | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/XYZReader/src/main/java/com/example/xyzreader/ui/ArticleDetailActivity.java b/XYZReader/src/main/java/com/example/xyzreader/ui/ArticleDetailActivity.java index 3e5168ca1..c11c914c4 100755 --- a/XYZReader/src/main/java/com/example/xyzreader/ui/ArticleDetailActivity.java +++ b/XYZReader/src/main/java/com/example/xyzreader/ui/ArticleDetailActivity.java @@ -41,6 +41,9 @@ public class ArticleDetailActivity extends AppCompatActivity private ViewPager mPager; private MyPagerAdapter mPagerAdapter; private ImageView mPhotoView; + + private String mCurrentPhotoUrl; + private int mCurrentPage; @Override protected void onCreate(Bundle savedInstanceState) { @@ -79,9 +82,10 @@ public void onPageSelected(int position) { findViewById(R.id.share_fab).setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { + if ((mCursor == null) || !mCursor.moveToPosition(mCurrentPage)) return; startActivity(Intent.createChooser(ShareCompat.IntentBuilder.from(ArticleDetailActivity.this) .setType("text/plain") - .setText("Some sample text") + .setText(getString(R.string.share_prefix) + mCursor.getString(ArticleLoader.Query.TITLE)) .getIntent(), getString(R.string.action_share))); } }); @@ -127,8 +131,6 @@ public void onLoaderReset(Loader cursorLoader) { mPagerAdapter.notifyDataSetChanged(); } - private String mCurrentPhotoUrl; - public void onUpdatePhoto (@NonNull String url, @NonNull Bitmap bitmap) { if (!url.equals(mCurrentPhotoUrl)) return; if (bitmap == null) return; @@ -147,6 +149,7 @@ public MyPagerAdapter(FragmentManager fm) { public void setPrimaryItem (ViewGroup container, int position, Object object) { super.setPrimaryItem(container, position, object); if (mCursor == null) return; + mCurrentPage = position; mCursor.moveToPosition(position); mCurrentPhotoUrl = mCursor.getString(ArticleLoader.Query.PHOTO_URL); if (object != null) { diff --git a/XYZReader/src/main/res/values/strings.xml b/XYZReader/src/main/res/values/strings.xml index 09f0cfe23..db8adea40 100755 --- a/XYZReader/src/main/res/values/strings.xml +++ b/XYZReader/src/main/res/values/strings.xml @@ -8,5 +8,6 @@ Share Article title photo + Now reading a great article!\n