Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with pipenv >= 2022.10.9 #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compatibility with pipenv >= 2022.10.9 #26

wants to merge 1 commit into from

Conversation

felixonmars
Copy link

Project._lockfile became a function instead of a property in pypa/pipenv@b3381ce, which is shipped in pipenv since version 2022.10.9.

Adding a simple compatibility fix here fixes it for me.

Fixes #25

@felixonmars
Fix compatibility with pipenv >= 2022.10.9
fa7cdcd 
`Project._lockfile` became a function instead of a property in pypa/pipenv@b3381ce, which is shipped in pipenv since version 2022.10.9.

Adding a simple compatibility fix here fixes it for me.

Fixes gsemet#25
@felixonmars
Copy link
Author

felixonmars commented Jan 4, 2023 •
edited
Loading

Note that the tests are still failing because pipenv moved away from pipfile completely which breaks the import of pipfile in test_parsing.py.

I have tried to rewrite the test logic to use plette following what pipenv did, but it turns out to be more complex than I thought.

@theCapypara theCapypara mentioned this pull request Jan 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest build of Pipenv breaks pipenv-to-requirements
1 participant
@felixonmars