Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for Config UI X experience #140

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

jlian
Copy link
Contributor

@jlian jlian commented Mar 21, 2022

This PR contains two small changes:

  1. Add "menu" as an option for configuring the RC info button. The menu button opens up the full menu for my Denon receiver where I can configure all the options. User can click the info button on the RC to change whatever they want and use the back button to get out of it. I've validated this change myself, it works, so I think it should be added as an option for Config UI X users.
  2. Change "slider" to "lightbulb" in the volume control accessory type dropdown. This clarifies the actual type of accessory that it uses. I feel this is important in one scenario: if user tries to say "turn off all lights in the living room" they wouldn't want the volume to be muted. With the clarification they can choose "fan" as the option more directly.

Great plug-in by the way!

@grzegorz914
Copy link
Owner

grzegorz914 commented Mar 21, 2022

Thanks for the PR.

@grzegorz914 grzegorz914 merged commit 1dafd17 into grzegorz914:master Mar 21, 2022
grzegorz914 added a commit that referenced this pull request Mar 21, 2022
- added PR [#140](#140)
- update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants