Terratest AWS module for RDS has issue with GetParameterValueForParameterOfRdsInstance function #675
Comments
|
Thanks for reporting! Would you be up for a PR to fix this? |
|
I have modified the related modules to make this work but it's a bit messy. Being very new to Go I had difficulties with combining the results of the DescribeDBParameters call in the GetAllParametersOfRdsInstanceE function. I wanted to have this function loop through the pages of the available parameters. So to get it working I setup the GetParameterValueForParameterOfRdsInstanceE function to also return the Marker token to the calling process and then setup a loop in the GetParameterValueForParameterOfRdsInstanceE function to use the token to reference the next set. I can submit PR with this fix..... |
|
PR welcome, thank you! Note that we probably have other code in this repo, and code in many other Go repos, that use the Marker token pattern to fetch all results if you need a reference. |
Bug report: github.com/gruntwork-io/terratest/modules/aws/rds.go has issue with GetParameterValueForParameterOfRdsInstance function and it's dependent function GetParameterValueForParameterOfRdsInstanceE. The process loads all the parameters from the parameter group for the specified RDS instance and tries to locate the specified parameter in the set, but in fact, it is not loading all parameters. The dependent AWS API call DescribeDBParameters, by default, only returns the first 100 parameters (in alphabetical order) and if your parameter group has more than 100 parameters and the parameter you are looking for is not in the first 100, the function throw errors, incorrectly reporting the parameter does not exist.
Recommend the functions support pagination using the Marker parameter to scan all the parameters, 100 at a time.
The text was updated successfully, but these errors were encountered: