Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default difficulty issue #42

Closed
akiomik opened this issue Jul 2, 2023 · 3 comments · Fixed by #43
Closed

Default difficulty issue #42

akiomik opened this issue Jul 2, 2023 · 3 comments · Fixed by #43
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@akiomik
Copy link

akiomik commented Jul 2, 2023

In PR #41, a default value was set for the difficulty of CLIArgs, which made it impossible to specify vanity-n-prefix or vanity-n-suffix unless --difficulty=0 is specified.
@grunch grunch added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 3, 2023
@grunch
Copy link
Owner

grunch commented Jul 3, 2023

Oh you are right, @ok300 if you have time to give it a look would be great 😃

@ok300 ok300 mentioned this issue Jul 4, 2023
Merged
@ok300
Copy link
Contributor

ok300 commented Jul 4, 2023

Good catch @akiomik

@grunch I just added a PR to revert it.

@grunch grunch closed this as completed in #43 Jul 5, 2023
@akiomik
Copy link
Author

akiomik commented Jul 5, 2023

Thanks❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Simplify handling of default difficulty" ok300/rana
3 participants
@grunch @akiomik @ok300