Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vim does not work properly #29

Open
gruis opened this issue Feb 11, 2012 · 3 comments
Open

.vim does not work properly #29

gruis opened this issue Feb 11, 2012 · 3 comments
Labels

Comments

@gruis
Copy link
Owner

gruis commented Feb 11, 2012

Vim and other similar shell commands expect to be working with a tty. When the server executes a shell command it uses popen3. Vim complains that STDIN and STDOUT are not TTYs. It then doesn't respond to navigation commands correctly.

Does this affect other commands, e.g.,. passwd?

@banister
Copy link
Contributor

In the case of issuing an actual edit or edit-method command though, I think this should execute on the client, with the server sending across the file. When the client has finished editing the file it should be sent back to the server and reloaded (or whatever). IMO the most common interactive shell command is the editor and so if we manage this on the client instead, you would have solved the 90% case. I don't think it's such an issue that .vim doesn't work, as they should really be using edit instead anyway ;)

To support what i described, we'll probably need to refactor the edit and edit-method commands in Pry itself

@gruis
Copy link
Owner Author

gruis commented Feb 13, 2012

That's a good point. It would be nice if edit and edit-method executed locally so that the user can work in their typical editor.

@gruis
Copy link
Owner Author

gruis commented Jul 28, 2012

3b4117c adds support for edit and edit-method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants