Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant subscribe issue when route change #394

Closed
Zkffkah opened this issue Jun 8, 2019 · 2 comments
Closed

Redundant subscribe issue when route change #394

Zkffkah opened this issue Jun 8, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed javascript Requires JS/React skills

Comments

@Zkffkah
Copy link

Zkffkah commented Jun 8, 2019

When you switch ticker, like currently in ltc and click btc, there will be three history change trigger (btc -> ltc -> btc)and result in three resubscribe. The latter two is redundant.
Here I switch from ltc to eos.


Also, there is a redundant coin in the subscribedCoins.

And, we need to fix the redundant resubscribe when switch from not coin route to coin route.

@Zkffkah Zkffkah added awaiting triage Bugs awaiting developer initial investigation bug Something isn't working labels Jun 8, 2019
@badgerwithagun badgerwithagun added good first issue Good for newcomers help wanted Extra attention is needed javascript Requires JS/React skills and removed awaiting triage Bugs awaiting developer initial investigation labels Jun 10, 2019
@badgerwithagun
Copy link
Member

Confirmed. Easy to replicate.

@badgerwithagun
Copy link
Member

Fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed javascript Requires JS/React skills
Projects
None yet
Development

No branches or pull requests

2 participants