From ccc9c736927f830ca8dab9f1d1a36848c2b909d9 Mon Sep 17 00:00:00 2001 From: wanlin du Date: Thu, 10 Nov 2022 11:39:45 -0800 Subject: [PATCH 1/3] Add documentation for Prometheus scrape interval and query daley. --- config/prometheus/README.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/config/prometheus/README.md b/config/prometheus/README.md index fafcdfc2..6aeb0f5d 100644 --- a/config/prometheus/README.md +++ b/config/prometheus/README.md @@ -29,3 +29,20 @@ The files [install-prometheus.yaml](install-prometheus.yaml) and [servicemonitors.yaml](servicemonitors.yaml) are taken from [istio/tools](https://github.com/istio/tools/), with configuration related to Istio left out. + +### Prometheus scrape_interval + +`scrape_interval` is how frequently the Prometheus to scrape targets, by default +it is set to +[1m](https://prometheus.io/docs/prometheus/latest/configuration/configuration/). +We set Prometheus scrape interval to be 1s as our tests typically last 30s. See + for details. + +### Delay to query + +We add 20s delay before collecting data for the test used Prometheus, see +details in . This time allows data +to become available +([cAdvisor housekeeping interval](https://github.com/google/cadvisor/blob/master/docs/runtime_options.md#housekeeping)) +and pulled by Prometheus +([Prometheus scrape interval](https://github.com/grpc/test-infra/pull/325)). From 097b02d7b8bea347bd59412696cb3fc28f949ece Mon Sep 17 00:00:00 2001 From: wanlin du Date: Thu, 17 Nov 2022 15:32:51 -0800 Subject: [PATCH 2/3] Address comment. --- config/prometheus/README.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/config/prometheus/README.md b/config/prometheus/README.md index 6aeb0f5d..e9fca9ec 100644 --- a/config/prometheus/README.md +++ b/config/prometheus/README.md @@ -30,19 +30,19 @@ The files [install-prometheus.yaml](install-prometheus.yaml) and [istio/tools](https://github.com/istio/tools/), with configuration related to Istio left out. -### Prometheus scrape_interval +### Prometheus scrape interval -`scrape_interval` is how frequently the Prometheus to scrape targets, by default -it is set to +The scrape interval (`scrape_interval`) determines how often Prometheus scrapes +targets. The default value for this interval is [1m](https://prometheus.io/docs/prometheus/latest/configuration/configuration/). -We set Prometheus scrape interval to be 1s as our tests typically last 30s. See - for details. +We change this interval in our configuration to 1s, since our tests typically +last only 30s. See for details. ### Delay to query -We add 20s delay before collecting data for the test used Prometheus, see -details in . This time allows data -to become available +We add 20s delay before collecting data from Prometheus, in the tests that use +Prometheus. This delay allows data to become available ([cAdvisor housekeeping interval](https://github.com/google/cadvisor/blob/master/docs/runtime_options.md#housekeeping)) and pulled by Prometheus -([Prometheus scrape interval](https://github.com/grpc/test-infra/pull/325)). +([Prometheus scrape interval](https://github.com/grpc/test-infra/pull/325)). See +details in . From aae227ffa89bf5f0e2dd72ac8684a02a1a096bd5 Mon Sep 17 00:00:00 2001 From: wanlin du Date: Thu, 17 Nov 2022 15:40:38 -0800 Subject: [PATCH 3/3] Address comment. --- config/prometheus/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/prometheus/README.md b/config/prometheus/README.md index e9fca9ec..15f522b6 100644 --- a/config/prometheus/README.md +++ b/config/prometheus/README.md @@ -38,11 +38,11 @@ targets. The default value for this interval is We change this interval in our configuration to 1s, since our tests typically last only 30s. See for details. -### Delay to query +### Query delay We add 20s delay before collecting data from Prometheus, in the tests that use Prometheus. This delay allows data to become available ([cAdvisor housekeeping interval](https://github.com/google/cadvisor/blob/master/docs/runtime_options.md#housekeeping)) and pulled by Prometheus ([Prometheus scrape interval](https://github.com/grpc/test-infra/pull/325)). See -details in . + for details.