Skip to content

Commit 80cb537

Browse files
authored
Merge pull request #2 from srikrsna-buf/Fix-example
Fix example
2 parents 403a111 + fc392e9 commit 80cb537

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

examples/helloworld/static_codegen_es/greeter_client.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var messages = require('./helloworld_pb');
2121
var services = require('./helloworld_grpc_pb');
2222

2323
var grpc = require('@grpc/grpc-js');
24+
var { create } = require('@bufbuild/protobuf');
2425

2526
function main() {
2627
var argv = parseArgs(process.argv.slice(2), {
@@ -34,16 +35,17 @@ function main() {
3435
}
3536
var client = new services.GreeterClient(target,
3637
grpc.credentials.createInsecure());
37-
var request = new messages.HelloRequest();
3838
var user;
3939
if (argv._.length > 0) {
40-
user = argv._[0];
40+
user = argv._[0];
4141
} else {
4242
user = 'world';
4343
}
44-
request.setName(user);
44+
var request = create(messages.HelloRequestSchema, {
45+
name: user,
46+
});
4547
client.sayHello(request, function(err, response) {
46-
console.log('Greeting:', response.getMessage());
48+
console.log('Greeting:', response.message);
4749
});
4850
}
4951

examples/helloworld/static_codegen_es/greeter_server.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@ var messages = require('./helloworld_pb');
2020
var services = require('./helloworld_grpc_pb');
2121

2222
var grpc = require('@grpc/grpc-js');
23+
var { create } = require('@bufbuild/protobuf');
2324

2425
/**
2526
* Implements the SayHello RPC method.
2627
*/
2728
function sayHello(call, callback) {
28-
var reply = new messages.HelloReply();
29-
reply.setMessage('Hello ' + call.request.getName());
29+
var reply = create(messages.HelloReplySchema, {
30+
message: 'Hello ' + call.request.name,
31+
});
3032
callback(null, reply);
3133
}
3234

examples/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"@grpc/proto-loader": "^0.6.0",
66
"async": "^1.5.2",
77
"google-protobuf": "^3.0.0",
8+
"@bufbuild/protobuf": "^2.7.0",
89
"@grpc/grpc-js": "^1.10.2",
910
"@grpc/grpc-js-xds": "^1.10.0",
1011
"@grpc/reflection": "^1.0.0",

0 commit comments

Comments
 (0)