Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: skip localities with zero weight when parsing the resource #5453

Closed
easwars opened this issue Jun 22, 2022 · 1 comment · Fixed by #5476
Closed

xdsclient: skip localities with zero weight when parsing the resource #5453

easwars opened this issue Jun 22, 2022 · 1 comment · Fixed by #5476

Comments

@easwars
Copy link
Contributor

easwars commented Jun 22, 2022

We do skip localities with zero weight here:

But, we have no tests for this.

@markdroth
Copy link
Member

FWIW, in C-core, we skip these localities inside of XdsClient when parsing the EDS resource. They never get returned from the XdsClient, so there's no need to deal with them in any of the LB policies.

@easwars easwars changed the title clusterresolver: add tests to ensure that localities with zero weight are skipped xdsclient: skip localities with zero weight when parsing the resource Jun 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants