Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] gRPC-Spring-Boot-Starter Documentation: Getting Started - Project Setup (Server and Client) Exhibitory Imagery #1077

Closed
arnoldmashava opened this issue Mar 26, 2024 · 3 comments · Fixed by #1078
Labels
bug Something does not work as expected

Comments

@arnoldmashava
Copy link
Contributor

¿Where is the exhibitory imagery pertaining to the Project Setup for the grpc-spring-server and Project Setup for the grpc-spring-client components in the Ver. 3.x Release iteration of the Documentation?

I was initially tempted to submit a Pull Request but that would have been a untidy Dirty-Dance, which without an admissible and valid source URL from which this imagery would be embedded, would translate to completely removing the intended visualizations on how the gRPC-Spring-Boot-Starter project should be setup.

Respectively, for the grpc-spring-server and grpc-spring-client components, the intended Documentation visualizations point to the following invalid sources:

  1. https://grpc-ecosystem.github.io/grpc-spring-boot-starter/assets/images/server-project-setup.svg

  2. https://grpc-ecosystem.github.io/grpc-spring-boot-starter/assets/images/client-project-setup.svg

Muchas Gracias.

@arnoldmashava arnoldmashava added the bug Something does not work as expected label Mar 26, 2024
@ST-DDT
Copy link
Collaborator

ST-DDT commented Mar 27, 2024

Thanks for bringing this to our attention and your quick fix.

@arnoldmashava
Copy link
Contributor Author

Thanks for bringing this to our attention and your quick fix.

It is such immense honor @ST-DDT - albeit the seemingly infinitesimal gravitas of my Dirty-Dancing moves, in the form of single-line and minor git commits.

The anticipation for my Wandering Eye is that of enhanced visual stimulus emanating from refined gRPC-Spring-Boot-Starter Documentation aesthetics - for the rendered outputs of both the English and 中文 *.md sets of source files into which the proposed amendments were petrissaged.

Herewith some Orange haze and Protobuf levitation:

>_ sudo ¡Muchas Gracias! --verbose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants