Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swagger bug] with google/protobuf/wrappers.proto #453

Closed
jinleileiking opened this issue Sep 5, 2017 · 1 comment
Closed

[swagger bug] with google/protobuf/wrappers.proto #453

jinleileiking opened this issue Sep 5, 2017 · 1 comment

Comments

@jinleileiking
Copy link

jinleileiking commented Sep 5, 2017

My pb:

  116 message UpdatePubNotifyURLConfigRequest {¬
  117     string App            = 1 [(validator.field) = {string_not_empty: true}];¬
  118     string Pubdomain      = 2 [(validator.field) = {string_not_empty: true}];¬
  119     google.protobuf.Int32Value  Notify           = 3;¬
  120     google.protobuf.StringValue StartNotifyURL = 4;¬
  121     google.protobuf.StringValue EndNotifyURL   = 5;¬
  122 }¬

The response generated by swagger in example request:

{
  "App": "string",
  "Pubdomain": "string",
  "Notify": {
    "value": 0
  },
  "StartNotifyURL": {
    "value": "string"
  },
  "EndNotifyURL": {
    "value": "string"
  }
}

In real response , it will be:

{
  "App": "string",
  "Pubdomain": "string",
  "Notify":  0,
  "StartNotifyURL": "string",
  "EndNotifyURL":  "string"
}
@achew22
Copy link
Collaborator

achew22 commented Dec 14, 2017

After #412 lands, we box/unbox the *Value types. If you would like to take that patch and extend it to have a test I'd be very happy to merge it. I'm going to close this since that PR tracks the work slightly better.

@achew22 achew22 closed this as completed Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants