Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error output titlecase instead of lowercase #243

Closed
nathanborror opened this issue Oct 21, 2016 · 1 comment
Closed

Error output titlecase instead of lowercase #243

nathanborror opened this issue Oct 21, 2016 · 1 comment

Comments

@nathanborror
Copy link
Contributor

The current error output is titlecase ({"Error": "...", "Code": "..."}) when it should be lowercase ({"error": "...", "code": "..."}). This appears to be due to errorBody implementing proto.Message interface but lacking protobuf tags needed to marshal correctly. When I patch errorBody with the following I end up with correct behavior:

type errorBody struct {
    Error string `protobuf:"bytes,1,name=error" json:"error"`
    Code  int    `protobuf:"bytes,2,name=code" json:"code"`
}
@tmc
Copy link
Collaborator

tmc commented Nov 5, 2016

This was closed by #244

@tmc tmc closed this as completed Nov 5, 2016
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants