Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is metadataAnnotators not []func(metadata.MD, *http.Request) #1107

Closed
liov opened this issue Jan 8, 2020 · 1 comment
Closed

Why is metadataAnnotators not []func(metadata.MD, *http.Request) #1107

liov opened this issue Jan 8, 2020 · 1 comment

Comments

@liov
Copy link

liov commented Jan 8, 2020

I don't think

for _, mda := range mux.metadataAnnotators {
		md = metadata.Join(md, mda(ctx, req))
	}

is better than

for _, mda := range mux.metadataAnnotators {
		mda(md, req)
	}
@achew22
Copy link
Collaborator

achew22 commented Jan 8, 2020

Unfortunately there is no enough information in this issue to determine what you think is wrong nor how we would go about fixing it. In the future, please use the issue template. If you would like to fill in the issue template and reopen I'm also receptive to that.

@achew22 achew22 closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants