Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading, table): loading cause children Component rerender, fix table type define #870

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

LEEHONCN
Copy link
Contributor

No description provided.

@LEEHONCN LEEHONCN requested a review from tongchuliu as a code owner March 12, 2021 06:01
@vercel
Copy link

vercel bot commented Mar 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/338LvcpxzzAitBHrqCUMjKVRhzQE
✅ Preview: https://gio-design-git-fix-loading-growingio.vercel.app

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #870 (fecaba8) into master (e2674b8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files         151      151              
  Lines        4866     4863       -3     
  Branches     1303     1302       -1     
==========================================
- Hits         4775     4772       -3     
  Misses         89       89              
  Partials        2        2              
Impacted Files Coverage Δ
src/components/table/Table.tsx 100.00% <ø> (ø)
src/components/loading/Loading.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2674b8...c905e4b. Read the comment docs.

@LEEHONCN LEEHONCN changed the title fix(loading): loading case children Component rerender fix(loading, table): loading case children Component rerender, fix table type define Mar 12, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gavin-hao gavin-hao merged commit 003ea9d into master Mar 12, 2021
@gavin-hao gavin-hao deleted the fix-loading branch March 12, 2021 08:44
@LEEHONCN LEEHONCN changed the title fix(loading, table): loading case children Component rerender, fix table type define fix(loading, table): loading cause children Component rerender, fix table type define Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants