Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): style scope error, fix mask do not disappear #863

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Mar 9, 2021

将 fade 的这些动画样式 移到 gio-modal-mask 作用域下 ,原来是 .gio-modal.fade-enter

@LEEHONCN LEEHONCN requested a review from gavin-hao as a code owner March 9, 2021 02:46
@vercel
Copy link

vercel bot commented Mar 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/6PLPEraN5XobW5Kiiecbu4GtxVLc
✅ Preview: https://gio-design-git-modal-fix-growingio.vercel.app

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #863 (a112155) into master (b4d0e47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         151      151           
  Lines        4893     4893           
  Branches     1304     1304           
=======================================
  Hits         4654     4654           
  Misses        235      235           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d0e47...e72e36a. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gavin-hao gavin-hao merged commit a73469e into master Mar 9, 2021
@gavin-hao gavin-hao deleted the modal-fix branch March 9, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modal] 如果不传入 destroyOnClose 那么close 后蒙层依然存在
2 participants