Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(steps): add steps component #766

Merged
merged 5 commits into from
Feb 5, 2021
Merged

feat(steps): add steps component #766

merged 5 commits into from
Feb 5, 2021

Conversation

nnmax
Copy link
Contributor

@nnmax nnmax commented Feb 3, 2021

No description provided.

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/cflv8j98p
✅ Preview: https://gio-design-git-steps.growingio.vercel.app

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #766 (52d1c03) into master (ec88ae4) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   89.68%   89.83%   +0.14%     
==========================================
  Files         148      150       +2     
  Lines        5041     5115      +74     
  Branches     1330     1352      +22     
==========================================
+ Hits         4521     4595      +74     
  Misses        514      514              
  Partials        6        6              
Impacted Files Coverage Δ
src/components/steps/Step.tsx 100.00% <100.00%> (ø)
src/components/steps/Steps.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec88ae4...50f2f60. Read the comment docs.

Copy link
Member

@jack0pan jack0pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最后,把注释的代码删掉吧。

// docs: {
// page: Docs,
// },
design: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先别放这个设计稿,后面放 GrowingIO Design Components 里的 frame

@@ -0,0 +1,28 @@
import { Props, Meta } from '@storybook/addon-docs/blocks';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants