Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu, layout): change menu design, refactor layout #763

Merged
merged 1 commit into from
Feb 7, 2021
Merged

feat(menu, layout): change menu design, refactor layout #763

merged 1 commit into from
Feb 7, 2021

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Feb 2, 2021

  1. change menu style
  2. add title inlineCollapsed props
  3. remove default open submenu
  4. add Layout.Header.HeaderSection, Layout.Header.HeaderDivider component
  5. add menu.Divider component

BREAKING CHANGE: 移除了默认打开submenu, 需要手动设置openkeys

@LEEHONCN LEEHONCN requested a review from Danny548326 as a code owner February 2, 2021 07:09
@vercel
Copy link

vercel bot commented Feb 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/6uadih2sa
✅ Preview: https://gio-design-git-fork-leehoncn-menu-update.growingio.vercel.app

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #763 (9adeb77) into master (5544047) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   89.83%   89.93%   +0.10%     
==========================================
  Files         150      151       +1     
  Lines        5115     5158      +43     
  Branches     1352     1360       +8     
==========================================
+ Hits         4595     4639      +44     
+ Misses        514      513       -1     
  Partials        6        6              
Impacted Files Coverage Δ
src/components/layout/layout.tsx 100.00% <ø> (ø)
src/components/menu/MenuTitle.tsx 100.00% <ø> (ø)
src/components/layout/content.tsx 100.00% <100.00%> (ø)
src/components/layout/header.tsx 100.00% <100.00%> (ø)
src/components/layout/sider.tsx 100.00% <100.00%> (ø)
src/components/layout/useSiders.ts 100.00% <100.00%> (ø)
src/components/menu/Divider.tsx 100.00% <100.00%> (ø)
src/components/menu/Menu.tsx 100.00% <100.00%> (ø)
src/components/menu/MenuContext.ts 100.00% <100.00%> (ø)
src/components/menu/MenuItem.tsx 100.00% <100.00%> (+6.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5544047...3913150. Read the comment docs.

@LEEHONCN LEEHONCN removed the request for review from Danny548326 February 2, 2021 08:46
@zzt1224 zzt1224 requested a review from Danny548326 February 3, 2021 02:29
@LEEHONCN LEEHONCN changed the title feat(menu): change menu design feat(menu, Layout): change menu design, refactor Layout Feb 4, 2021
@LEEHONCN LEEHONCN requested a review from huskylengcb as a code owner February 5, 2021 05:54
@LEEHONCN LEEHONCN changed the title feat(menu, Layout): change menu design, refactor Layout feat(menu, Layout): change menu design, refactor layout Feb 5, 2021
@LEEHONCN LEEHONCN changed the title feat(menu, Layout): change menu design, refactor layout feat(menu, layout): change menu design, refactor layout Feb 5, 2021
@LEEHONCN LEEHONCN requested a review from zzt1224 as a code owner February 7, 2021 02:51
1. change menu style  2. add title inlineCollapsed props 3.  remove default open submenu

BREAKING CHANGE: 移除了默认打开submenu, 需要手动设置openkeys
@Danny548326 Danny548326 merged commit 5f9e399 into growingio:master Feb 7, 2021
@jack0pan jack0pan added this to the 2021 Q1 milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants