Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add Row and Col components #734

Merged
merged 2 commits into from
Jan 25, 2021
Merged

feat(grid): add Row and Col components #734

merged 2 commits into from
Jan 25, 2021

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN requested a review from iahu as a code owner January 21, 2021 10:57
@vercel
Copy link

vercel bot commented Jan 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/6j7rr3611
✅ Preview: https://gio-design-git-fork-leehoncn-grid.growingio.vercel.app

@iahu
Copy link
Contributor

iahu commented Jan 22, 2021

这跟我原作不是一个东西,不要用同一个名字

src/components/grid/Grid.stories.tsx Outdated Show resolved Hide resolved
src/components/grid/Grid.stories.tsx Outdated Show resolved Hide resolved
@Danny548326 Danny548326 requested a review from jack0pan January 25, 2021 06:31
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #734 (6e9f2ac) into master (2cf9932) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   88.01%   88.19%   +0.17%     
==========================================
  Files         142      145       +3     
  Lines        4748     4818      +70     
  Branches     1252     1271      +19     
==========================================
+ Hits         4179     4249      +70     
  Misses        564      564              
  Partials        5        5              
Impacted Files Coverage Δ
src/components/grid/grid.tsx 100.00% <ø> (ø)
src/components/grid/col.tsx 100.00% <100.00%> (ø)
src/components/grid/row.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf9932...4913af2. Read the comment docs.

@jack0pan jack0pan merged commit 57d63a1 into growingio:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Grid] 新增 Grid 栅格组件
4 participants