Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): add onblur and remove onSelect from props #624

Merged
merged 2 commits into from
Dec 17, 2020
Merged

fix(date-picker): add onblur and remove onSelect from props #624

merged 2 commits into from
Dec 17, 2020

Conversation

WORLDI
Copy link
Contributor

@WORLDI WORLDI commented Dec 17, 2020

affects: @gio-design/components, website

add onblur to dateRangePicker and remove onSelect from props

@gio-design/components, website@20.12.1

  • 日期选择器
    • 给dateRangePicker设置失焦隐藏
    • 将onSelect从参数列表里删除
    • 修复dateRangePicker点击取消或者失焦时行为和点击确定按钮一样的问题

@gio-design/components, website@20.12.1

  • datePicker
    • Defocus setting for picker Ranger
    • Delete onSelect from props
    • Fixed the same behavior of daterangepicker when clicking cancel or defocus as when clicking OK

@WORLDI WORLDI requested a review from itiiss as a code owner December 17, 2020 03:43
@vercel
Copy link

vercel bot commented Dec 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/ewdtt5i8q
✅ Preview: https://gio-design-git-branchsign.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #624 (7961537) into master (e9cca2b) will decrease coverage by 0.06%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   82.84%   82.78%   -0.07%     
==========================================
  Files         129      129              
  Lines        4262     4270       +8     
  Branches     1119     1123       +4     
==========================================
+ Hits         3531     3535       +4     
- Misses        728      732       +4     
  Partials        3        3              
Impacted Files Coverage Δ
...mponents/src/components/date-picker/datePicker.tsx 63.63% <33.33%> (-0.52%) ⬇️
...nts/src/components/date-picker/dateRangePicker.tsx 57.89% <42.85%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9cca2b...b497d2d. Read the comment docs.

@WORLDI WORLDI changed the title fix(date-picker): add onblur to dateRangePicker and remove onSelect from props fix(date-picker): add onblur and remove onSelect from props Dec 17, 2020
affects: @gio-design/components, website

add onblur to dateRangePicker and remove onSelect from props
@jack0pan jack0pan merged commit e6d9dcd into growingio:master Dec 17, 2020
@WORLDI WORLDI deleted the branch_sign branch December 22, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants