Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix select group listHeight #600

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

berber1016
Copy link
Contributor

affects: @gio-design/components

fix select group listHeight

@berber1016 berber1016 requested a review from zzt1224 as a code owner December 9, 2020 10:35
@vercel
Copy link

vercel bot commented Dec 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/bnwj4c9jn
✅ Preview: https://gio-design-git-select.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #600 (99f72dd) into master (bbd4853) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   83.12%   83.12%   -0.01%     
==========================================
  Files         127      127              
  Lines        4225     4224       -1     
  Branches     1118     1117       -1     
==========================================
- Hits         3512     3511       -1     
  Misses        710      710              
  Partials        3        3              
Impacted Files Coverage Δ
packages/components/src/components/list/list.tsx 92.78% <ø> (ø)
...ckages/components/src/components/select/Select.tsx 94.76% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd4853...063ba6f. Read the comment docs.

affects: @gio-design/components
@huskylengcb huskylengcb merged commit 70a9b01 into growingio:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants