Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(listPicker): 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 #2134

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix(listPicker): 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 #2134

merged 2 commits into from
Jan 5, 2023

Conversation

BraveHead
Copy link
Contributor

@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gio-design ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 10:30AM (UTC)

@render
Copy link

render bot commented Jan 5, 2023

Your Render PR Server URL is https://gio-design-pr-2134.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cer81o4gqg459fbe3r8g.

@BraveHead BraveHead requested a review from Danny548326 January 5, 2023 07:49
@BraveHead BraveHead linked an issue Jan 5, 2023 that may be closed by this pull request
[listPicker]: 在非受控情况下开启allowClear,点击清除Icon的时候无效 #2133
Closed
@BraveHead BraveHead force-pushed the fix/listpicker_uncontrolled_clear branch from 8fec300 to 4cccb5a Compare January 5, 2023 08:16
@BraveHead BraveHead force-pushed the fix/listpicker_uncontrolled_clear branch from 4cccb5a to 5b5d79e Compare January 5, 2023 08:27
@BraveHead BraveHead changed the title Fix/listpicker uncontrolled clear fix(listPicker): 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 Jan 5, 2023
@BraveHead BraveHead force-pushed the fix/listpicker_uncontrolled_clear branch from 5b5d79e to 5571fce Compare January 5, 2023 08:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 9 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BraveHead BraveHead merged commit f2b6043 into master Jan 5, 2023
@BraveHead BraveHead deleted the fix/listpicker_uncontrolled_clear branch January 5, 2023 10:59
growingio-bot pushed a commit that referenced this pull request Jan 5, 2023
@semantic-release-bot
chore(release): version 23.6.6 changelog
834da25 
## [23.6.6](v23.6.5...v23.6.6) (2023-01-05)

### Bug Fixes

* **listPicker:** 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 ([#2134](#2134)) ([f2b6043](f2b6043)), closes [#2133](#2133)
@growingio-bot
Copy link
Collaborator

🎉 This PR is included in version 23.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

jack0pan pushed a commit that referenced this pull request Jan 5, 2023
@BraveHead @jack0pan
fix(listPicker): 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 (#2134)
7767a11 
* fix:  修复在非受控情况下开启allowClear,点击清除Icon的时候无效 (#2133)

* fix unit-test

Co-authored-by: zhangshun <zhangshun@growingio.com>
Co-authored-by: YanHui <yanhui@growingio.com>
jack0pan pushed a commit that referenced this pull request Jan 5, 2023
@semantic-release-bot @jack0pan
chore(release): version 23.6.6 changelog
5b13f80 
## [23.6.6](v23.6.5...v23.6.6) (2023-01-05)

### Bug Fixes

* **listPicker:** 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 ([#2134](#2134)) ([f2b6043](f2b6043)), closes [#2133](#2133)
growingio-bot pushed a commit that referenced this pull request Jan 11, 2023
@semantic-release-bot
chore(release): version 23.6.6 changelog
85297cb 
## [23.6.6](v23.6.5...v23.6.6) (2023-01-11)

### Bug Fixes

* **listPicker:** 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 ([#2134](#2134)) ([7767a11](7767a11)), closes [#2133](#2133)
growingio-bot pushed a commit that referenced this pull request Jan 18, 2023
@semantic-release-bot
chore(release): version 23.6.6 changelog
56d1de5 
## [23.6.6](v23.6.5...v23.6.6) (2023-01-18)

### Bug Fixes

* **listPicker:** 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 ([#2134](#2134)) ([7767a11](7767a11)), closes [#2133](#2133)
growingio-bot pushed a commit that referenced this pull request Jan 25, 2023
@semantic-release-bot
chore(release): version 23.7.0 changelog
8afa491 
# [23.7.0](v23.6.5...v23.7.0) (2023-01-25)

### Bug Fixes

* **listPicker:** 修复在非受控情况下开启allowClear,点击清除Icon的时候无效 ([#2134](#2134)) ([7767a11](7767a11)), closes [#2133](#2133)

### Features

* **past-time-picker:** 增加“显示绝对时间”特性 ([#2137](#2137)) ([f5c6870](f5c6870))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quesle Quesle Quesle approved these changes

@Danny548326 Danny548326 Awaiting requested review from Danny548326

Assignees
No one assigned
Labels
released on @master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[listPicker]: 在非受控情况下开启allowClear,点击清除Icon的时候无效
3 participants
@BraveHead @growingio-bot @Quesle