Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list, list-picker, select, cascader): add deps style #1838

Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix(list, list-picker, select, cascader): add deps style #1838

merged 1 commit into from
Feb 10, 2022

Conversation

nnmax
Copy link
Contributor

@nnmax nnmax commented Feb 10, 2022

No description provided.

@nnmax nnmax requested a review from berber1016 February 10, 2022 03:30
@vercel
Copy link

vercel bot commented Feb 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/F8E9yfp3fE6ezw1cuAKkzBTYDbHw
✅ Preview: https://gio-design-git-liststyledeps-growingio.vercel.app

berber1016
berber1016 reviewed Feb 10, 2022
View reviewed changes
src/list/style/index.less Outdated

.@{list-prefix-cls} {
display: flex;
flex-flow: column;
margin: 0;
padding: 8px;
row-gap: 4px;

// 下面这个样式是不是没有用了？
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是没用了

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nnmax nnmax merged commit 40b5a35 into master Feb 10, 2022
@nnmax nnmax deleted the listStyleDeps branch February 10, 2022 04:34
jack0pan pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): version 22.12.12 changelog
40e5162 
## [22.12.12](v22.12.11...v22.12.12) (2022-02-10)

### Bug Fixes

* **list, list-picker, select, cascader:** add deps style ([#1838](#1838)) ([40b5a35](40b5a35))
* **list:** fix list cascader item position clip error ([#1749](#1749)) ([181c28f](181c28f))
@jack0pan
Copy link
Member

🎉 This PR is included in version 22.12.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berber1016 berber1016 berber1016 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnmax @jack0pan @berber1016