Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): list multiple style error #1668

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix(list): list multiple style error #1668

merged 1 commit into from
Dec 14, 2021

Conversation

berber1016
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/5CXFknckFWWfG786gmbTA2V3MDUM
✅ Preview: https://gio-design-git-fix-list-growingio.vercel.app

@semgrep-app
Copy link

semgrep-app bot commented Dec 13, 2021

Semgrep was unable to comment inline on the following findings:

In src/list/inner/baseItem.tsx:92-111

It is a good practice to avoid spreading for JSX attributes. This forces the code to be explicit about which props are given to the component. This avoids situations where warnings are caused by invalid HTML props passed to HTML elements, and further, it avoids passing unintentional extra props by malicious actors. Instead, consider explicitly passing props to the component.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing


In src/list/inner/baseItem.tsx:92-111

It is a good practice to avoid spreading for JSX attributes. This prevents accidentally passing dangerouslySetInnerHTML to an element.

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing


In src/list/inner/baseItem.tsx:92-111

ref usage found, refs give direct DOM access and may create a possibility for XSS

Click a link below to tell your Security Team if this comment was:
👍 useful
👎 not useful (false positive)
🤔 confusing

How do I suppress this?

@codeclimate
Copy link

codeclimate bot commented Dec 14, 2021

Code Climate has analyzed commit 8d8031b and detected 0 issues on this pull request.

View more on Code Climate.

@zhuzilv zhuzilv self-requested a review December 14, 2021 02:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@berber1016 berber1016 merged commit ff1c61d into master Dec 14, 2021
@berber1016 berber1016 deleted the fix-list branch December 14, 2021 03:39
jack0pan pushed a commit that referenced this pull request Dec 14, 2021
## [22.5.3](v22.5.2...v22.5.3) (2021-12-14)

### Bug Fixes

* **cascader:** item 点击方法不稳定 ([#1669](#1669)) ([8e8244a](8e8244a))
* **InputButton:** fix icon-prefix-cls of InputButton ([#1675](#1675)) ([980f51b](980f51b))
* **legacy/list-pro:** use legacy/checkbox in /legacy/list-pro ([#1677](#1677)) ([9f8dde8](9f8dde8))
* **list:** list multiple style error ([#1668](#1668)) ([ff1c61d](ff1c61d))
@jack0pan
Copy link
Member

🎉 This PR is included in version 22.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants