Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): update modal style #1027

Merged
merged 1 commit into from
May 31, 2021
Merged

fix(modal): update modal style #1027

merged 1 commit into from
May 31, 2021

Conversation

tongchuliu
Copy link
Contributor

根据设计师要求 调整弹窗底部按钮间距为8px
https://www.figma.com/file/ZIYRsKMYnXJBastapZCVKt/GrowingIO-Design-System?node-id=0%3A16184

@tongchuliu tongchuliu requested a review from gavin-hao as a code owner May 31, 2021 07:48
@vercel
Copy link

vercel bot commented May 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/CMZKPriAsDtXQrTc1JrhyUodxSiu
✅ Preview: https://gio-design-git-modal-style-growingio.vercel.app

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #1027 (8ac8028) into master (0e459c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         4912      4912           
  Branches      1315      1315           
=========================================
  Hits          4912      4912           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e459c2...8ac8028. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tongchuliu
Copy link
Contributor Author

设计师已验收

@gavin-hao gavin-hao merged commit c057ff1 into master May 31, 2021
@gavin-hao gavin-hao deleted the modal-style branch May 31, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants