Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): support sorter and filter controll #1016

Merged
merged 1 commit into from
May 28, 2021

Conversation

LEEHONCN
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/9KokbbBbhAwUbtHgPZHDxsLPKj4X
✅ Preview: https://gio-design-git-sorter-filter-controlled-growingio.vercel.app

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1016 (a7b196d) into master (75abb96) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       150    -1     
  Lines         4885      4912   +27     
  Branches      1301      1315   +14     
=========================================
+ Hits          4885      4912   +27     
Impacted Files Coverage Δ
src/components/table/FilterPopover.tsx 100.00% <100.00%> (ø)
src/components/table/Table.tsx 100.00% <100.00%> (ø)
src/components/table/Title.tsx 100.00% <100.00%> (ø)
src/components/table/hook/useEllipsisTooltip.tsx 100.00% <100.00%> (ø)
src/components/table/hook/useFilter.tsx 100.00% <100.00%> (ø)
src/components/table/hook/usePagination.tsx 100.00% <100.00%> (ø)
src/components/table/hook/useSelection.tsx 100.00% <100.00%> (ø)
src/components/table/hook/useSorter.tsx 100.00% <100.00%> (ø)
src/components/drawer/drawer.tsx 100.00% <0.00%> (ø)
src/utils/type.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75abb96...a7b196d. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@berber1016 berber1016 merged commit bf9c6e2 into master May 28, 2021
@berber1016 berber1016 deleted the sorter-filter-controlled branch May 28, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants