Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent usage of a parameter in Route Class #71

Closed
jamescr opened this issue Oct 4, 2017 · 2 comments
Closed

Inconsistent usage of a parameter in Route Class #71

jamescr opened this issue Oct 4, 2017 · 2 comments
Assignees

Comments

@jamescr
Copy link
Collaborator

jamescr commented Oct 4, 2017

The stops parameter of Route Class is a list the is being assigned with two different object types during the default execution of the script.

In osm_connector it is a list of strings, where each string corresponds to the node ID of the stop in OSM. In the default creator the stop parameter is changed to a list of osm2gtfs Stop Objects.

@pantierra
Copy link
Contributor

This is related and hs been addressed within the work on the data structure #30 - at least for the standard stops_creator. In order to allow backwards compatibility with existing creators, this logic has been moved to the routes_creator_incofer and routes_creator_fenix.

@pantierra
Copy link
Contributor

Resolved with accepted PR #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants