-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add city name to stop #108
Comments
At least Navitia should add the city automatically to stops based on information from OSM. If you add this to stop names, you would see the city twice in Transportr. |
In Transportr Nicaragua city names are missing from the stop names, so for example I only see 'Hospital'. Do I need to configure anything anywhere in order to automatically add that name? |
You need to talk to the navitia people about this. AFAIK it needs administrative boundaries with admin_level = 8 (cities) to build streets and addresses. Also, make sure that you included OSM data in your server for this region. |
All the GTFS i encountered doesn't specify city names in stop names. I don't think adding this information is a god idea if it's a workaround specific to navitia. |
I agree : I don't think adding city to stop name is a good GTFS practice. |
@ialokim I'm not sure to understand your question. Are you asking this in navitia or in osm2gtfs ? |
I was asking about navitia, sorry, my fault.
So can this city name automatically be appended to stop names? Or can it be accessed within the API when requesting stop details? |
To keep it simple, Navitia loads cities from OSM with the boundaries. Each point (stop, Point of Interest or address) is associated with |
Okay perfect, thanks a lot for this explanation! So definitly there's no need to add city names to stops inside osm2gtfs. Testing it on our own navitia instance, it seems the label is always equal to the name. We've included OSM data for Nicaragua. Do we need some extra settings and would it work on navitia.io anyway or is it a problem with the OSM data? Looking at pte's source code, I'm fearing this |
PTE should already take the city of the first |
Looking at the code, it seems it only does in some cases (hardcoded, in German language), see here. That would definitely not work for Nicaragua. |
I am afraid, you are looking at the wrong code. Check this: https://github.com/schildbach/public-transport-enabler/blob/master/enabler/src/de/schildbach/pte/AbstractNavitiaProvider.java#L244 |
Okay, my fault, the |
It is used by Transportr for location auto-completion.
I suggest you inspect the API results of your instance directly to see if administrative regions exist there.
|
Okay, perfect.
We already know that they are not, but I wanted to be sure they could be shown by Transportr. Thanks a lot for your explanations! |
I think this could be closed. |
@grote Can you give Mikolai the permission to close issues? I can do it but he can't.
|
When generating national GTFS feeds it is important to have the possibility to add the city name to a stop because it is very likely that one stop name exists in various cities.
Example: Managua, Mercado Mayoreo (Bus stop Mercado Mayoreo in Managua, Nicaragua)
The text was updated successfully, but these errors were encountered: