From 089268ebc4df080e824a2820a864e287967fbf71 Mon Sep 17 00:00:00 2001 From: Keegan Witt Date: Tue, 26 Sep 2023 14:21:33 -0400 Subject: [PATCH] Replace `.size() == 0` with `isEmpty()` --- .../java/org/codehaus/gmavenplus/model/internal/Version.java | 4 ++-- .../org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java | 2 +- src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/codehaus/gmavenplus/model/internal/Version.java b/src/main/java/org/codehaus/gmavenplus/model/internal/Version.java index 3a252ee2..4e780a18 100644 --- a/src/main/java/org/codehaus/gmavenplus/model/internal/Version.java +++ b/src/main/java/org/codehaus/gmavenplus/model/internal/Version.java @@ -65,7 +65,7 @@ public Version(final int newMajor, final int newMinor, final int newRevision, fi major = newMajor; minor = newMinor; revision = newRevision; - if (newTag == null || newTag.length() != 0) { + if (newTag == null || !newTag.isEmpty()) { tag = newTag; } else { tag = null; @@ -109,7 +109,7 @@ public Version(final int newMajor) { * @return The version parsed from the string */ public static Version parseFromString(final String version) { - if (version == null || version.length() == 0) { + if (version == null || version.isEmpty()) { throw new IllegalArgumentException("Version must not be null or empty."); } String[] split = version.split("[._-]", 4); diff --git a/src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java b/src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java index 77251f70..177d7c46 100644 --- a/src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java +++ b/src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java @@ -382,7 +382,7 @@ protected Properties setupProperties() { @SuppressWarnings({"rawtypes", "unchecked"}) protected List setupLinks() throws ClassNotFoundException, InvocationTargetException, IllegalAccessException, InstantiationException { List linksList = new ArrayList(); - if (links != null && links.size() > 0) { + if (links != null && !links.isEmpty()) { Class linkArgumentClass = null; if (this.linkArgumentClass == null) { if (groovyAtLeast(GROOVY_1_6_0_RC2)) { diff --git a/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java b/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java index 6fef3d1d..39697081 100644 --- a/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java +++ b/src/main/java/org/codehaus/gmavenplus/util/ClassWrangler.java @@ -85,7 +85,7 @@ public String getGroovyVersionString() { try { Class groovySystemClass = getClass("groovy.lang.GroovySystem"); String ver = (String) invokeStaticMethod(findMethod(groovySystemClass, "getVersion")); - if (ver != null && ver.length() > 0) { + if (ver != null && !ver.isEmpty()) { groovyVersion = ver; } } catch (ClassNotFoundException | IllegalArgumentException | InvocationTargetException | IllegalAccessException e) { @@ -98,7 +98,7 @@ public String getGroovyVersionString() { try { Class invokerHelperClass = getClass("org.codehaus.groovy.runtime.InvokerHelper"); String ver = (String) invokeStaticMethod(findMethod(invokerHelperClass, "getVersion")); - if (ver != null && ver.length() > 0) { + if (ver != null && !ver.isEmpty()) { groovyVersion = ver; } } catch (ClassNotFoundException | IllegalArgumentException | InvocationTargetException | IllegalAccessException e) {