Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open for edit" / "Revert" ignores group permissions #200

Open
Bu11etmagnet opened this issue Aug 2, 2019 · 1 comment
Open

"Open for edit" / "Revert" ignores group permissions #200

Bu11etmagnet opened this issue Aug 2, 2019 · 1 comment
Assignees
Labels

Comments

@Bu11etmagnet
Copy link

Describe the bug
"Open for edit" and "Revert" change only user permissions. They leave group permissions unchanged.

To Reproduce
Steps to reproduce the behavior:

  1. ls -l foo shows r--r--r-- foo.py
  2. Right-click on foo.py in the project tree and select "P4 > Open for add/edit"
  3. ls -l foo shows rw-r--r-- foo.py (contrast this with the result of p4 edit)
  4. Right-click on foo.py in the project tree and select "P4 > Revert"
  5. ls -l foo shows r--r--r-- foo.py
  6. p4 edit foo
  7. ls -l foo shows rw-rw-r-- foo.py
  8. Right-click on foo.py in the project tree and select "P4 > Revert"
  9. ls -l foo shows r--rw-r-- foo.py (no write permission should be set)

Expected behavior
Behavior should be the same as the Perforce client: both user and group permissions should be changed.

Desktop (please complete the following information):

  • OS: XUbuntu 18.04.2 LTS
  • Plugin version 0.10.8
  • IDE and version: PyCharm 2019.2 (Community Edition)
    Build #PC-192.5728.105, built on July 23, 2019
    Runtime version: 11.0.3+12-b304.10 amd64
    VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
    Linux 4.15.0-55-generic
    GC: ParNew, ConcurrentMarkSweep
    Memory: 1981M
    Cores: 8
    Registry:
    Non-Bundled Plugins: PerforceIC
@groboclown groboclown self-assigned this Aug 3, 2019
@groboclown groboclown added the bug label Aug 3, 2019
@groboclown
Copy link
Owner

Thanks for the bug report. It looks like an issue with the underlying Perforce provided integration library. There have been some newer releases of that jar that might contain a fix for this, otherwise I'll need to add another patch to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants