Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupSet validation is missing valid cases #15

Open
scalbertm opened this issue Sep 29, 2021 · 0 comments
Open

GroupSet validation is missing valid cases #15

scalbertm opened this issue Sep 29, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@scalbertm
Copy link
Contributor

Empty group name

In the last branch, GroupSet cannot be empty but there is no issue with a set named {id}.

Rule and GroupSetEditor validation should add case groupSet === "" && type === SetType.PREFIX
Adding both PREFIX and SUFFIX has no reason since they would undistinguishable

groupSetEditor

GroupSetEditor does not allow to have the same group name for a PREFIX and a SUFFIX (while the rest of the system allows it)

@scalbertm scalbertm added enhancement New feature or request bug Something isn't working good first issue Good for newcomers and removed enhancement New feature or request labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant