From 5d90aef27e0d064aa4a1ae6ce9c3489078c1d536 Mon Sep 17 00:00:00 2001 From: Vitalii Gridnev Date: Wed, 4 Sep 2024 19:09:55 +0300 Subject: [PATCH] Revert "Fix hash spreading in HashPartitionConsumer (#4364)" This reverts commit e3c776faf566de3104335dfa71b2507b43447ebd. --- ydb/library/yql/dq/runtime/dq_output_consumer.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/ydb/library/yql/dq/runtime/dq_output_consumer.cpp b/ydb/library/yql/dq/runtime/dq_output_consumer.cpp index ca5204c151b3..a52597b6567d 100644 --- a/ydb/library/yql/dq/runtime/dq_output_consumer.cpp +++ b/ydb/library/yql/dq/runtime/dq_output_consumer.cpp @@ -21,11 +21,6 @@ using namespace NKikimr; using namespace NMiniKQL; using namespace NUdf; -inline ui64 SpreadHash(ui64 hash) { - // https://probablydance.com/2018/06/16/fibonacci-hashing-the-optimization-that-the-world-forgot-or-a-better-alternative-to-integer-modulo/ - return ((unsigned __int128)hash * 11400714819323198485llu) >> 64; -} - class TDqOutputMultiConsumer : public IDqOutputConsumer { public: @@ -195,9 +190,6 @@ class TDqOutputHashPartitionConsumer : public IDqOutputConsumer { hash = CombineHashes(hash, HashColumn(keyId, columnValue)); } - - hash = SpreadHash(hash); - return hash % Outputs.size(); } @@ -209,8 +201,6 @@ class TDqOutputHashPartitionConsumer : public IDqOutputConsumer { hash = CombineHashes(hash, HashColumn(keyId, values[KeyColumns[keyId].Index])); } - hash = SpreadHash(hash); - return hash % Outputs.size(); } @@ -314,8 +304,6 @@ class TDqOutputHashPartitionConsumerScalar : public IDqOutputConsumer { hash = CombineHashes(hash, HashColumn(keyId, values[KeyColumns_[keyId].Index])); } - hash = SpreadHash(hash); - return hash % Outputs_.size(); } @@ -513,9 +501,6 @@ class TDqOutputHashPartitionConsumerBlock : public IDqOutputConsumer { } hash = CombineHashes(hash, keyHash); } - - hash = SpreadHash(hash); - return hash % Outputs_.size(); }