Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The current dark mode implementation breaks with version bump of AdminLTE to v3.1.0 #84

Closed
gridhead opened this issue Apr 10, 2021 · 1 comment · Fixed by #85
Closed

The current dark mode implementation breaks with version bump of AdminLTE to v3.1.0 #84

gridhead opened this issue Apr 10, 2021 · 1 comment · Fixed by #85
Assignees
@gridhead
Labels
bug Something isn't working refactoring Implement the same thing but in a better way superficial Changes are mostly cosmetic

Comments

@gridhead
Copy link
Owner

There have been some compromises made within the code to allow for a better dark mode experience when using the AdminLTE v3.1.0-rc which are natively implemented by the newer AdminLTE v3.1.0. Replacing the older version with the newer version breaks due to the configurations made to accommodate with the dark mode and should be promptly removed.
@gridhead gridhead added bug Something isn't working superficial Changes are mostly cosmetic refactoring Implement the same thing but in a better way labels Apr 10, 2021
@gridhead gridhead self-assigned this Apr 10, 2021
@gridhead gridhead linked a pull request Apr 10, 2021 that will close this issue
Version bump from release candidate #85
Merged
@gridhead
Copy link
Owner Author

Fixed with #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gridhead gridhead

Labels
bug Something isn't working refactoring Implement the same thing but in a better way superficial Changes are mostly cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version bump from release candidate gridhead/supervisor-frontend-service
1 participant
@gridhead