Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationale behind DiscreteModelPortion inheritance relation #644

Closed
amartinhuertas opened this issue Aug 18, 2021 · 6 comments
Closed

Rationale behind DiscreteModelPortion inheritance relation #644

amartinhuertas opened this issue Aug 18, 2021 · 6 comments
Assignees
@fverdugo

Comments

@amartinhuertas
Copy link
Member

Hi @fverdugo,

is there a rationale behind this inheritance relationship?

https://github.com/gridap/Gridap.jl/blob/master/src/Geometry/DiscreteModelPortions.jl#L4

I would say it is a typo, isn't? Perhaps I am missing something ...

Let me know your thoughts!
@fverdugo
Copy link
Member

fverdugo commented Aug 18, 2021 •
edited
Loading

It looks it should be <: DiscreteModel{Dc,Dp} right?

@amartinhuertas
Copy link
Member Author

Yes, I think so. I will PR this change, ok?

@fverdugo
Copy link
Member

OK!

@fverdugo
Copy link
Member

with some test calling num_cell_dims, num_point_dims

@amartinhuertas
Copy link
Member Author

sure ... this is what I am writing now ...

@amartinhuertas
Copy link
Member Author

Worked it out in PR #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fverdugo fverdugo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartinhuertas @fverdugo