-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that min.node.size is strictly enforced. #143
Comments
Just to add a little more context, the behavior of the randomForest package is discussed here. We still intend to update the behavior of our implementation to properly enforce |
Hi @jtibshirani I'd be happy to continue contributing via PRs to grf. I was thinking either this one or any of the below:
... or any other suggestions you or the team may have. Thanks! |
Thanks for reaching out, @ras44! Let's start with #420 (and move the conversation there). If you're interested in doing this, could you please prepare a short document to start the conversation about how you envision the feature (in terms of scope, what kinds of functionality we should have, what types of forests the function can be applied to, if / how we should set up a cobalt dependency, etc.)? |
The implementation of |
Currently, we don't prevent splits from occurring that could result in nodes with size less than
min.node.size
. Instead, the algorithm simply stops splitting if a node's size is less than or equal tomin.node.size
.Although this is also the current behavior in both ranger and the original randomForest package, it's not intuitive and can be quite misleading. We should look into updating the splitting algorithm so that
min.node.size
is enforced as a true minimum.The text was updated successfully, but these errors were encountered: