table ids are now prefixed by "index_table_" to correct HTML document validity #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idity of the generated HTML, which was seeing the same id being attributed multiple times in the same document
|
Looks good, will make sure the tests pass & merge in when I get a chance. |
| @@ -108,8 +108,9 @@ module Views | |||
| class IndexAsTable < ActiveAdmin::Component | |||
|
|
|||
| def build(page_presenter, collection) | |||
| debugger | |||
There was a problem hiding this comment.
Good eye, was just testing locally & noticed that
@TiagoCardoso1983 - will you amend your commit to remove that & force a push back up to this branch?
|
Speaking of, @macfanatic do you have any idea what's wrong with our Travis builds? |
|
@daxter - I'm not familiar with Travis, but I can see for instance that there are 15 cukes that fail, related to filters & scoping of index listings. Was going to pair with someone to see what could be done about that. |
|
ups, sorry about that, will take care of it. |
|
hope there's no more garbage left :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed here: #1965 (comment)
It would be good though to the IndexTableFor class being specced in isolation.