Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jQuery 1.9 support in checkbox toggler #1947

Merged
merged 1 commit into from
Mar 5, 2013
Merged

Fix jQuery 1.9 support in checkbox toggler #1947

merged 1 commit into from
Mar 5, 2013

Conversation

ai
Copy link
Contributor

@ai ai commented Feb 27, 2013

Fix issue #1872 with Toggle All function for batch actions

@pomnikita
Copy link

+1

1 similar comment
@ariabov
Copy link

ariabov commented Feb 28, 2013

+1

@EddM
Copy link

EddM commented Feb 28, 2013

+1, but there's some similar use of attr() in the specs that should probably be updated to use prop(), also.

Edit: and should also be updated to test against jquery 1.9?

@macfanatic
Copy link
Contributor

Can you update the test suite to actually test the scenario you've fixed? If so, I'll gladly merge this in as it's bugging me in my projects as well.

@ai
Copy link
Contributor Author

ai commented Mar 4, 2013

Um… I think support fixes doesn’t need tests, because test willn’t pass without jQuery 1.9. Also it will very bad, to have special tests for every jQuery release. Like test, that we doesn’t have .live calls.

@macfanatic
Copy link
Contributor

Was more of a question in theory than if you would do it, I'm not a JS expert :) You bring up an excellent point however.

macfanatic added a commit that referenced this pull request Mar 5, 2013
Fix jQuery 1.9 support in checkbox toggler
@macfanatic macfanatic merged commit 7d05578 into activeadmin:master Mar 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants