Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-6198 Convert SocialMedia block to WYSIWYG #623

Merged
merged 3 commits into from
Aug 18, 2021
Merged

PLANET-6198 Convert SocialMedia block to WYSIWYG #623

merged 3 commits into from
Aug 18, 2021

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Jun 30, 2021 •
edited
Loading

Description

See https://jira.greenpeace.org/browse/PLANET-6198

In addition to the WYSIWYG conversion, I've done a couple of things:

  • Removed old shortcake conversion code
  • Fixed the folders/files/components case from Socialmedia to SocialMedia
  • Split the code for better performance
  • Removed facebook_page_url attribute since we can directly use social_media_url instead

Testing

Either on local or on the test instance add a Social Media block and make sure all embeds work as expected. You can also directly check it on this page that I set up for UAT 🙂

@mleray mleray added the WIP label Jun 30, 2021
@mleray mleray self-assigned this Jun 30, 2021
@mleray mleray force-pushed the planet-6198 branch 2 times, most recently from 155f1a8 to 9468d5f Compare June 30, 2021 12:20
@mleray mleray changed the title Planet 6198 PLANET-6198 Convert SocialMedia block to WYSIWYG Jun 30, 2021
@mleray mleray force-pushed the planet-6198 branch 5 times, most recently from 1efff08 to 094a0bf Compare June 30, 2021 12:51
@planet-4
Copy link
Contributor

planet-4 commented Jun 30, 2021 •
edited
Loading

Test instance is ready 🚀

🌑 sinope | admin | blocks report | CircleCI | composer-local.json

⌚ 2021.08.18 08:33:18

@mleray mleray force-pushed the planet-6198 branch 2 times, most recently from 66047dc to cd765be Compare June 30, 2021 13:58
@mleray mleray requested review from a team, lithrel and sagarsdeshmukh and removed request for a team June 30, 2021 14:31
@mleray mleray added Review UAT needed This PR requires User Acceptance Tests before merge and removed WIP labels Jun 30, 2021
@mleray mleray marked this pull request as ready for review June 30, 2021 14:31
GP-Dan-Tovbein
GP-Dan-Tovbein previously approved these changes Jun 30, 2021
View reviewed changes
Inwerpsel
Inwerpsel suggested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Inwerpsel Inwerpsel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to save the output of frontendRendered in the block as it's HTML. Then we don't need to render another block on the front end, since those are really bad for performance.

assets/src/blocks/SocialMedia/SocialMediaBlock.js Outdated Show resolved Hide resolved
@mleray mleray force-pushed the planet-6198 branch 4 times, most recently from fb61b1e to 953bced Compare July 2, 2021 12:53
@mleray mleray added UAT Passed User Acceptance Tests passed and removed UAT needed This PR requires User Acceptance Tests before merge labels Jul 30, 2021
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 2, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at c7f05932
4f8e269 
/unhold c1dbab3e-2987-4504-8da0-87844600e44f
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 2, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 0fed36ca
7c4b887 
/unhold 27f56379-0cd6-4064-a12b-fc44563ced62
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 2, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 8c792ec5
058202f 
/unhold 02c9701b-b4c9-4b9f-b7da-47d565a0454b
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 2, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 2feb6b2e
ec6afe5 
/unhold 8a99c44b-0966-488a-9fac-6dcc875048e3
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 3, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at feb9643b
56e0bf9 
/unhold d01f41ba-dc78-4363-b979-b06cee9196d1
@mleray mleray requested a review from Inwerpsel August 3, 2021 08:23
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 16, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 87b773d6
dbfac46 
/unhold 176cd2c9-fb3d-4f31-8535-7f807fc5b220
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 16, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at ed82b835
356d37f 
/unhold ffbb5b5c-36e2-4220-b991-cd29b3693b26
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 17, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 7ca2e2fe
761a06a 
/unhold 2b6b8a0d-d06d-457d-a6b6-4e9d031c44a5
comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 17, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at 4d9a1080
a009d8f 
/unhold 618da2eb-3e2d-4f24-8369-95cc44c226b0
@mleray mleray requested a review from Inwerpsel August 18, 2021 07:07
@mleray
PLANET-6198 Convert SocialMedia block to WYSIWYG
e820676 
This commit also includes code splitting for the SocialMedia block
Inwerpsel
Inwerpsel approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@Inwerpsel Inwerpsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🍺

comzeradd pushed a commit to greenpeace/planet4-test-sinope that referenced this pull request Aug 18, 2021
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#623 at e8206768
106bb30 
/unhold b1bd5661-8111-4be6-ad55-4f0923b47746
@mleray mleray merged commit 393b94a into master Aug 18, 2021
@mleray mleray deleted the planet-6198 branch August 18, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inwerpsel Inwerpsel Inwerpsel approved these changes

@lithrel lithrel Awaiting requested review from lithrel

@sagarsdeshmukh sagarsdeshmukh Awaiting requested review from sagarsdeshmukh

@GP-Dan-Tovbein GP-Dan-Tovbein Awaiting requested review from GP-Dan-Tovbein

Assignees

@mleray mleray

Labels
Review [Test Env] sinope UAT Passed User Acceptance Tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mleray @planet-4 @sagarsdeshmukh @Inwerpsel @GP-Dan-Tovbein