Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Secure GitHub webhooks #11

Closed
joeworkman opened this issue Mar 2, 2022 · 1 comment
Closed

feature: Secure GitHub webhooks #11

joeworkman opened this issue Mar 2, 2022 · 1 comment
Assignees

Comments

@joeworkman
Copy link

A clear and concise description of what you want the system to do.

The webhooks feature cannot currently be used properly with Github. The reason for this is that the web hook header needs to be compared securely for each request. It's not as simple as just comparing the strings in the web hook header.

Here are the docs for securing the web hooks for Github. https://docs.github.com/en/developers/webhooks-and-events/webhooks/securing-your-webhooks

@greenpau
Copy link
Owner

@joeworkman , please test it with latest https://github.com/greenpau/caddy-git/releases/tag/v1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants