-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confidence intervals for PennText accuracies #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
added a commit
to greenelab/scihub-manuscript
that referenced
this pull request
Jan 31, 2018
Adds 95% confidence intervals calculated in greenelab/scihub#50 greenelab/library-access#25
@Publicus any PR feedback will be addressed in a subsequent PR. |
dhimmel
added a commit
to greenelab/scihub-manuscript
that referenced
this pull request
Jan 31, 2018
Adds 95% confidence intervals calculated in greenelab/scihub#50 greenelab/library-access#25 Merges #49
dhimmel
added a commit
to greenelab/scihub-manuscript
that referenced
this pull request
Jan 31, 2018
This build is based on ab9ca60. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/scihub-manuscript/builds/335817496 https://travis-ci.org/greenelab/scihub-manuscript/jobs/335817497 [ci skip] The full commit message that triggered this build is copied below: Confidence intervals for proportions on article subsets (#49) Adds 95% confidence intervals calculated in greenelab/scihub#50 greenelab/library-access#25 Merges #49
dhimmel
added a commit
to greenelab/scihub-manuscript
that referenced
this pull request
Jan 31, 2018
This build is based on ab9ca60. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/scihub-manuscript/builds/335817496 https://travis-ci.org/greenelab/scihub-manuscript/jobs/335817497 [ci skip] The full commit message that triggered this build is copied below: Confidence intervals for proportions on article subsets (#49) Adds 95% confidence intervals calculated in greenelab/scihub#50 greenelab/library-access#25 Merges #49
Great! I look forward to looking through these changes; I'll do so tomorrow! |
Okay, we're hoping to resubmit the paper ASAP... potentially today or tomorrow so sooner the better. |
Just a note for future readers that I've just now left a comment on this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same approach as greenelab/scihub#50. Uses Jeffreys method for binomial proportion confidence intervals.