Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confidence intervals for PennText accuracies #25

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Jan 31, 2018

Same approach as greenelab/scihub#50. Uses Jeffreys method for binomial proportion confidence intervals.

dhimmel added a commit to greenelab/scihub-manuscript that referenced this pull request Jan 31, 2018
@dhimmel
Copy link
Contributor Author

dhimmel commented Jan 31, 2018

@Publicus any PR feedback will be addressed in a subsequent PR.

@dhimmel dhimmel merged commit 398d760 into greenelab:master Jan 31, 2018
@dhimmel dhimmel deleted the intervals branch January 31, 2018 20:47
dhimmel added a commit to greenelab/scihub-manuscript that referenced this pull request Jan 31, 2018
dhimmel added a commit to greenelab/scihub-manuscript that referenced this pull request Jan 31, 2018
This build is based on
ab9ca60.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/scihub-manuscript/builds/335817496
https://travis-ci.org/greenelab/scihub-manuscript/jobs/335817497

[ci skip]

The full commit message that triggered this build is copied below:

Confidence intervals for proportions on article subsets (#49)

Adds 95% confidence intervals calculated in
greenelab/scihub#50
greenelab/library-access#25

Merges #49
dhimmel added a commit to greenelab/scihub-manuscript that referenced this pull request Jan 31, 2018
This build is based on
ab9ca60.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/scihub-manuscript/builds/335817496
https://travis-ci.org/greenelab/scihub-manuscript/jobs/335817497

[ci skip]

The full commit message that triggered this build is copied below:

Confidence intervals for proportions on article subsets (#49)

Adds 95% confidence intervals calculated in
greenelab/scihub#50
greenelab/library-access#25

Merges #49
@jglev
Copy link

jglev commented Jan 31, 2018

Great! I look forward to looking through these changes; I'll do so tomorrow!

@dhimmel
Copy link
Contributor Author

dhimmel commented Jan 31, 2018

Okay, we're hoping to resubmit the paper ASAP... potentially today or tomorrow so sooner the better.

@jglev
Copy link

jglev commented Feb 1, 2018

Just a note for future readers that I've just now left a comment on this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants