Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade some versions + sonar version from 9.3 to 9.8 #13

Merged
merged 12 commits into from
Jan 3, 2023
Merged

Upgrade some versions + sonar version from 9.3 to 9.8 #13

merged 12 commits into from
Jan 3, 2023

Conversation

oussamaLaribi
Copy link
Contributor

No description provided.

@dedece35 dedece35 self-assigned this Dec 15, 2022
@dedece35 dedece35 added 🚀 enhancement New feature or request android Something tied to the android OS labels Dec 15, 2022
@dedece35
Copy link
Member

Hi @oussamaLaribi ,
I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies.
Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi , I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies. Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

Hi @dedece35, Okay I'll do it. Thanks.

oussamaLaribi and others added 4 commits December 20, 2022 09:33
@oussamaLaribi
Merge branch 'main' into main
d9213e3
@oussamaLaribi
-Upgrade sonarjava
d43f245 
-Upgrade sonar.analyzerCommons
-Upgrade sonar-packaging
-Fix dependency versions
-Enable skipDependenciesPackaging
-Add maven maven-shade-plugin for packaging
@oussamaLaribi
-Upgrade sonarjava to latest version.
a8ffc7d
@oussamaLaribi
Reported modifications (ecoCode)
1095bbe
@oussamaLaribi
Copy link
Contributor Author

Hi, @dedece35. It's ready for review.

@oussamaLaribi oussamaLaribi changed the title Upgrade some versions + sonar version from 9.3 to 9.7 Upgrade some versions + sonar version from 9.3 to 9.8 Dec 26, 2022
dedece35
dedece35 requested changes Jan 1, 2023
View reviewed changes
dedece35
dedece35 requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oussamaLaribi, I'm ok with this PR.
But can you report your corrections about plugin maven-shade to correct WARNINGs during build phase, please ?

@oussamaLaribi
Copy link
Contributor Author

Hi @oussamaLaribi, I'm ok with this PR. But can you report your corrections about plugin maven-shade to correct WARNINGs during build phase, please ?

Hi @dedece35, Okay I'll do it. Thanks.

@dedece35 dedece35 merged commit b5adf39 into green-code-initiative:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

Assignees

@dedece35 dedece35

Labels
android Something tied to the android OS 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oussamaLaribi @dedece35