From 3d14679e184dc319f1a9fcaf6c4eb359528b4bd7 Mon Sep 17 00:00:00 2001
From: utarwyn <maxime.malgorn@laposte.net>
Date: Thu, 16 Nov 2023 22:53:32 +0100
Subject: [PATCH] Add build number to manifest (ecoCode#185)

---
 CHANGELOG.md         |  4 +++
 sonar-plugin/pom.xml | 59 +++++++++++++++++++++++++++++++-------------
 2 files changed, 46 insertions(+), 17 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0d8aebf..4f40b47 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+-   [ecoCode#185](https://github.com/green-code-initiative/ecoCode/issues/185) Add build number to manifest
+
 ### Fixed
 
 -   [#30](https://github.com/green-code-initiative/ecoCode-javascript/issues/30) Fix typo in EC12 rule
diff --git a/sonar-plugin/pom.xml b/sonar-plugin/pom.xml
index f33e065..30f0855 100644
--- a/sonar-plugin/pom.xml
+++ b/sonar-plugin/pom.xml
@@ -49,14 +49,15 @@
         <project.build.sourceEncoding>${encoding}</project.build.sourceEncoding>
         <project.reporting.outputEncoding>${encoding}</project.reporting.outputEncoding>
 
-        <ecocode-rules-specifications.version>0.0.6</ecocode-rules-specifications.version>
-        <sonarqube.version>9.4.0.54424</sonarqube.version>
-        <sonar-javascript.version>9.13.0.20537</sonar-javascript.version>
-        <sonar-packaging.version>1.21.0.505</sonar-packaging.version>
-        <sonar-analyzer-commons.version>2.5.0.1358</sonar-analyzer-commons.version>
-        <maven-exec.version>3.1.0</maven-exec.version>
-        <maven-shade.version>3.4.1</maven-shade.version>
-        <license-maven-plugin.version>4.1</license-maven-plugin.version>
+        <version.ecocode-rules-specifications>0.0.6</version.ecocode-rules-specifications>
+        <version.sonarqube>9.4.0.54424</version.sonarqube>
+        <version.sonar-javascript>9.13.0.20537</version.sonar-javascript>
+        <version.sonar-packaging>1.23.0.740</version.sonar-packaging>
+        <version.sonar-analyzer-commons>2.5.0.1358</version.sonar-analyzer-commons>
+        <version.buildnumber>3.1.0</version.buildnumber>
+        <version.maven-exec>3.1.0</version.maven-exec>
+        <version.maven-shade>3.4.1</version.maven-shade>
+        <version.license-maven-plugin>4.1</version.license-maven-plugin>
 
         <junit.version>5.9.3</junit.version>
         <mockito.version>5.3.1</mockito.version>
@@ -69,21 +70,21 @@
         <dependency>
             <groupId>io.ecocode</groupId>
             <artifactId>ecocode-rules-specifications</artifactId>
-            <version>${ecocode-rules-specifications.version}</version>
+            <version>${version.ecocode-rules-specifications}</version>
             <classifier>javascript</classifier>
         </dependency>
 
         <dependency>
             <groupId>org.sonarsource.sonarqube</groupId>
             <artifactId>sonar-plugin-api</artifactId>
-            <version>${sonarqube.version}</version>
+            <version>${version.sonarqube}</version>
             <scope>provided</scope>
         </dependency>
 
         <dependency>
             <groupId>org.sonarsource.javascript</groupId>
             <artifactId>sonar-javascript-plugin</artifactId>
-            <version>${sonar-javascript.version}</version>
+            <version>${version.sonar-javascript}</version>
             <type>sonar-plugin</type>
             <scope>provided</scope>
         </dependency>
@@ -91,7 +92,7 @@
         <dependency>
             <groupId>org.sonarsource.analyzer-commons</groupId>
             <artifactId>sonar-analyzer-commons</artifactId>
-            <version>${sonar-analyzer-commons.version}</version>
+            <version>${version.sonar-analyzer-commons}</version>
         </dependency>
 
         <dependency>
@@ -131,22 +132,27 @@
             <plugin>
                 <groupId>org.sonarsource.sonar-packaging-maven-plugin</groupId>
                 <artifactId>sonar-packaging-maven-plugin</artifactId>
-                <version>${sonar-packaging.version}</version>
+                <version>${version.sonar-packaging}</version>
                 <extensions>true</extensions>
                 <configuration>
                     <pluginKey>ecocodejavascript</pluginKey>
                     <pluginName>${project.name}</pluginName>
                     <pluginClass>io.ecocode.javascript.JavaScriptPlugin</pluginClass>
                     <sonarLintSupported>false</sonarLintSupported>
-                    <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
+                    <pluginApiMinVersion>${version.sonarqube}</pluginApiMinVersion>
                     <skipDependenciesPackaging>true</skipDependenciesPackaging>
                     <jreMinVersion>${java.version}</jreMinVersion>
+                    <archive>
+                        <manifestEntries>
+                            <Implementation-Build>${buildNumber}</Implementation-Build>
+                        </manifestEntries>
+                    </archive>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>${maven-shade.version}</version>
+                <version>${version.maven-shade}</version>
                 <executions>
                     <execution>
                         <phase>package</phase>
@@ -176,10 +182,29 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>buildnumber-maven-plugin</artifactId>
+                <version>${version.buildnumber}</version>
+                <executions>
+                    <execution>
+                        <phase>validate</phase>
+                        <goals>
+                            <goal>create</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <configuration>
+                    <doCheck>false</doCheck>
+                    <doUpdate>false</doUpdate>
+                    <getRevisionOnlyOnce>true</getRevisionOnlyOnce>
+                    <revisionOnScmFailure>0</revisionOnScmFailure>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>exec-maven-plugin</artifactId>
-                <version>${maven-exec.version}</version>
+                <version>${version.maven-exec}</version>
                 <executions>
                     <execution>
                         <id>eslint-plugin-clean</id>
@@ -234,7 +259,7 @@
             <plugin>
                 <groupId>com.mycila</groupId>
                 <artifactId>license-maven-plugin</artifactId>
-                <version>${license-maven-plugin.version}</version>
+                <version>${version.license-maven-plugin}</version>
                 <configuration>
                     <properties>
                         <owner>Green Code Initiative</owner>