Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graz should not provide queryClient #141

Open
dalechyn opened this issue Apr 3, 2024 · 0 comments
Open

Graz should not provide queryClient #141

dalechyn opened this issue Apr 3, 2024 · 0 comments

Comments

@dalechyn
Copy link
Contributor

dalechyn commented Apr 3, 2024

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Graz allows you to pass a queryClient, but it is not open enough.

In my case – I need to add a PersistentQueryClientProvider and I'm not able to do so unless I'm introducing two query clients which is unwanted.

return (
<QueryClientProvider key="graz-provider" client={queryClient} {...props}>
<ClientOnly>
{children}
<GrazEvents />
</ClientOnly>
</QueryClientProvider>

Describe the solution you'd like

This will cause a major release, but graz should not provide nor create query clients at all. wagmi doesn't do this since ^2.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

...

Additional context

Add any other context or screenshots about the feature request here.

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant