Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golf=tee and golf=green should be changed to draw on top of golf=fairway #4147

Closed
leijurv opened this issue May 16, 2020 · 5 comments
Closed

Comments

@leijurv
Copy link

leijurv commented May 16, 2020

Expected behavior

"Golf Course Tee Box" and "Golf Course Putting Green" should draw on top of "Golf Course Fairway"

"Golf Course Sand Trap" already renders on top of "Golf Course Fairway", as one would expect.

Actual behavior

"Golf Course Fairway" draws on top of "Golf Course Tee Box" and "Golf Course Putting Green", defeating the point, and requiring very bad workarounds such as what you can see at https://www.openstreetmap.org/edit#map=17/37.42721/-122.43336

Links and screenshots illustrating the problem

https://www.openstreetmap.org/edit#map=17/37.42721/-122.43336

@Adamant36
Copy link
Contributor

It's not rendering that way because of the golf tags. Since none of them are currently implemented. It's because of how the other added tags are rendered in priority.

@leijurv
Copy link
Author

leijurv commented May 16, 2020

OK then I suggest that tee box and putting green, get a slightly lighter shade of green, and be drawn on top.

@Adamant36
Copy link
Contributor

There's already a couple of issues open for rendering golf tags. I'll probably work on it myself when I get some free time soon. Maybe comment what you want in one of them. Since this will more then likely get lost when it's closed.

@leijurv
Copy link
Author

leijurv commented May 16, 2020

?

Tee box and putting green should get a slightly lighter shade of green than fairway, and be rendered on top? I'm not sure what else I might describe.

Exactly like how sand traps are rendered right now, but lime instead of yellow, should be applied to putting green and tee box.

@imagico
Copy link
Collaborator

imagico commented May 16, 2020

What you see rendered in the area you linked to is landuse=grass and natural=sand, not golf=* tags.

Hence this seems to be a duplicate of #661 - closing as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants