-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent rendering of railway station buildings in dark brown #3257
Comments
It is indeed public_transport=station.
If that is the case that seems to be a but, for example https://www.openstreetmap.org/way/299305320 renders like it should. Let me know if you have a counterexample. |
Yet carto doesn't do similar when combined with railway=station. Note the difference in the two Shepherd's Bush stations. https://www.openstreetmap.org/#map=19/51.50494/-0.21840
However I don't see them as relating to a building. They represent the whole of station. There should only be one tag per station, but often stations will contain multiple buildings. This leads to inconsistency in how station buildings will be tagged. I think they should have the darker render only if tagged [MM: edited to remove duplicate text] |
Reopening - although it is not yes clear to me exactly what your suggested solution would be. |
I guess it might be a tagging scheme problem. |
There are 2 problems here:
I would recommend dropping rendering for
|
I don't see justification for that claim. For example |
It certainly can be tagged identically to a building, but we shouldn't
necessarily encourage or endorse such tagging as superior to the other
options. Giving a special rendering to buildings with
public=transport_station implies that this tag should be added to the
building area.
|
On the other hand we do special rendering for airport terminals and I see that makes sense. |
Yes, but the airport terminal is defined as a building, while a train
or bus station often includes areas of tracks and platforms which are
not always inside of a building.
|
Do you see (or envision) some other tagging that could be used as a universal indicator of terminal building? |
I'm sorry if I wasn't clear. I think that it is good to check for In contrast: "railway=station should be applied to an area covering the whole station, or preliminary on a node placed at the center of the station area" - so this is usually not a building, but either a node or a larger area. For amenity=bus_station: "A bus station consists of several bus stops, usually allowing people to travel in many different directions" - no mention of a building, and almost 2/3rds are mapped as nodes. public_transport=station: " If the station is completely (or most of it) inside a station building, the building is the outline. If the station is not fully or mostly covered by a building, any existing buildings should be mapped at their place inside the station outline." - 42k mapped as nodes, only 17k as ways, only 12k combined with Since mappers do not usually add the station tags to a building feature, we should not rely on this for rendering. It gives confusing feedback to mappers, and usually doesn't work. |
No need to be sorry, I understand you. I just asked if you can see the universal solution for this, because you're also very active with tagging documentation and maybe you have some good idea to solve it. |
https://www.openstreetmap.org/way/41599363
Given the tags I thought it should be the standard building colour, but it's dark, as if it contains the tag building=train_station, but Overpass doesn't return one.
I notice 'public_transport=station' is included with building=train_station in buildings.mss under #buildings-major but the examples I've seen render that as a lighter colour when it's a polygon.
The text was updated successfully, but these errors were encountered: