Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please display amenity=public_bath on the map #2856

Closed
ghost opened this issue Sep 21, 2017 · 23 comments · Fixed by #3066
Closed

Please display amenity=public_bath on the map #2856

ghost opened this issue Sep 21, 2017 · 23 comments · Fixed by #3066

Comments

@ghost
Copy link

ghost commented Sep 21, 2017

No description provided.

@kocio-pl kocio-pl added this to the New features milestone Sep 21, 2017
@kocio-pl
Copy link
Collaborator

How should it be displayed?
We have 1332 uses and a wiki page:

https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Dpublic_bath

@ghost
Copy link
Author

ghost commented Sep 21, 2017

Just the name would suffice. It is currently only displayed when public_bath is combined with building, but not when on a separate node or area. Maybe the same icon iD uses for public_bath could be used?

By the way, there are many thermal baths wrongly tagged as swimming_pool or water_park (presumably because their names aren't displayed otherwise) so the number of uses would certainly increase if public_bath were rendered.

@RobJN
Copy link

RobJN commented Sep 24, 2017

Having been to Japan this year for sotm, I can see how this would be useful for Japan (assuming they tag onsens this way). All the tourist maps showed these as significant map features.

@kocio-pl
Copy link
Collaborator

Just the name would suffice. It is currently only displayed when public_bath is combined with building, but not when on a separate node or area.

I'm not sure how to display it as an area, but I would rather display general brown dot than just a name to show it's more pointy feature.

Maybe the same icon iD uses for public_bath could be used?

I will check that later.

@ghost
Copy link
Author

ghost commented Sep 25, 2017

Or maybe something like this could be used as icon:

public_bath
public_bath.svg.txt

@kocio-pl
Copy link
Collaborator

Nice idea, but what color should we use then - brown probably?

@ghost
Copy link
Author

ghost commented Sep 25, 2017

I don't know your guidelines, but brown seems to be fine.

@kocio-pl
Copy link
Collaborator

In general (social) amenities are brown, but I wonder if other color would not work better in this case. It can be also other icon design, like bathtub with two simplified persons (like in a playground or prison for example). Could anybody test them and try how the icons look like on the rendering?

@HolgerJeromin
Copy link
Contributor

Is a bath not a leisure thing and could be colored green?

@kocio-pl
Copy link
Collaborator

We should test. I guess proposed symbol is so abstract, that can be hard to recognize without proper color (like blue), but bathtub might be different color wise.

@RobJN
Copy link

RobJN commented Sep 26, 2017

In Japan there seemed to be a pretty universal symbol which is close to the proposed but the bath is circular. These were seen as an amenity so brown would be ok but I think blue works well too.

onsen

@MKuranowski
Copy link
Contributor

Hi, so I actually did some work on this - I prepared two icons:

  • The standard Japanese onsen icon:
    steam

  • And, as an experiment "a person in water" icon:
    man

Here are exmaple renderings with the onsen icon:
steam_blue
steam_brown
steam_green

With the "experiment" icon:
man_blue
man_brown
man_green

I personally would go for the brown-onsen icon, but it's open for discussion :)

@kocio-pl
Copy link
Collaborator

Thanks! While both icons are nice, I like experimental icon more, because it's less abstract and not tied to Japan (for example Iceland is also known for such amenities). However I think the space between water line and a person shape should be bigger to make them distinct.

Brown works the best for me - this shade of blue is about transport/journey and green is more about physical activity, while this amenity is about resting.

@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented Feb 11, 2018

I like experimental icon more, because it's less abstract and not tied to Japan

👍

@Tomasz-W
Copy link

@MKuranowski Can you add a little bit of space between body and shoulders? At the moment, this icon reminds me more a meditating monk.

@MKuranowski
Copy link
Contributor

Hmm, is this ok, or should I add even more space?
man

Rendering:
rendering_2

And, I'm sorry @Tomasz-W, but I kind don't get what you mean by "a little bit of space between body and shoulders". Do you literally mean a white box between body and arms?

@kocio-pl
Copy link
Collaborator

Thanks, now the space is OK for me!

Current shape of man has no visible space between shoulders and body, adding a narrow gaps would make it more clear probably. If you're not sure what do we mean, just publish the vector icon as gist so we could modify it.

@MKuranowski
Copy link
Contributor

I'm still kinda not sure, so just to be safe, I have uploaded it here...:
https://gist.github.com/MKuranowski/d43f172510d9a1908615c00150b5b596

@kocio-pl
Copy link
Collaborator

Thanks - I meant something like this:
public_bath-1

It would be good to make this shape more pixel aligned and symmetric (currently it's a bit shifted and made of parts) - could you fix it?

@MKuranowski
Copy link
Contributor

Oh, I see now, thanks!

So I tried making it more aligned, but still the arm separators and the head is ¼ px off, otherwise the icon started looking wired...
man

(Aligned to full pixel, for reference only:)
man_fullyaligned

I'll squash it into one path just before PR, it makes it easier to edit the icon like this 😃.

@kocio-pl
Copy link
Collaborator

Great! Pixel aligning is good to have, but most of the times the matrix is too small, so it's not always possible if we want some meaningful shape. First image is nice (at least at this scale), so we can go on with it. Since I find it to be mostly complete solution of this issue, could you prepare a pull request?

BTW: I have also found mikveh tagged this way, which is a ritual in Judaism, so this icon is better than just a Japan hot bath symbol.

@MKuranowski
Copy link
Contributor

So, PR created 😄

@polarbearing
Copy link
Contributor

double bath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants