Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering support for natural=valley, natural=ridge for the name=* key #2774

Closed
aaronstar opened this issue Aug 24, 2017 · 4 comments
Closed

Comments

@aaronstar
Copy link

aaronstar commented Aug 24, 2017

Hi,
I would like to see rendering support for natural=valley and natural=ridge (only for the name=* key).
It would be useful to label the names of these features. (A text label)
Other lesser used natural=* tags in my opinion probably are not yet at the stage where they should be rendered in any capacity, however as natural=valley and natural=ridge form the basis of some pretty significant topographical features it may be useful to render their name.

Currently, the only similar kind of features are natural=water and or waterway=river, which there may not always be a river, and the river or water-body may have a different alignment to the valley. The valley name may also extend only for a certain portion of the river section if this was the case. Similarly, natual=cliff or natural=peak is a currently rendered similar tag for natural=ridge, but a ridge may not always have a cliff, a cliff may have a different name, and it may not be a peak either.

A potential issue is where users mistakenly tag natural=valley or natural=ridge with other features like waterway=river. Hopefully this should not happen very frequently, as the name tags would overlap.

Let me know your thoughts,

Regards,
Aaron

@kocio-pl kocio-pl added the text label Aug 24, 2017
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Aug 24, 2017
@Ircama
Copy link
Contributor

Ircama commented Sep 6, 2017

I also wish to see the rendering of valleys and other major natural features.

Some aspects have already been discussed in this repository, like at Rendering of natural=ridge and at Rendering of valleys, ridges and other mountain elements, with a reviewed and unmerged PR.

In summary, even if JOSM already incudes a preset for valleys based on the current definition in the wiki and this feature is increasingly used as way (check also with http://taghistory.raifer.tech), there is an open discussion at the wiki talk tab for natural=valley on the most appropriate data model to be adopted, which still needs some time to be resumed and addressed.

Meanwhile, OpenTopoMap already renders names of valleys, riges, aretes, symbols of peaks with cross.

@Tomasz-W
Copy link

@kocio-pl Please close this ticket as a duplicate of #788 meta ticket. Move further discussion there.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 5, 2018

@Ircama, would you be willing to do a new PR for just natural=arete and natural=ridge? I believe there was wide agreement that the name should be shown for these features. In particular, everyone agreed that natural=arete should be rendered with a linear symbol and name, when tagged on a way. There was some disagreement about if there should be a rendering for unnamed ridges tagged on ways, but everyone agreed to rendering named ridges.

@Ircama
Copy link
Contributor

Ircama commented Oct 5, 2018

@jeisenbe, thanks for the recap, these features have been pretty largely discussed. Anyway I'm afraid I cannot take care of them within a short time; it is something I would have liked to do, but unfortunately at the moment my free time is too limited.
The main code is already in #2138 and I think that what would still be needed is to agree on the most appropriate symbol for arete and ridge. Examples are already in that PR, but some additional research should be done.
OpenTopoMap renders labels of ridges without a symbol.
Osmand renders them with a smooth line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants