From 7216bb45bb1804667757cc2c0d8fcc99aeeb9837 Mon Sep 17 00:00:00 2001 From: Mateusz Konieczny Date: Sat, 11 May 2019 23:36:09 +0200 Subject: [PATCH] stop rendering shop=yes fixes #3697 Originally only shop with their own icons were rendered. Later popular shop values were also rendered - as dots without icons. This was deliberate decision to not render tags with mistakes like shop=supermarkte Since #2415 all shop values except 'no', 'vacant', 'closed', 'disused', 'empty' are rendered. Given that any, even never used shop value is rendered and `shop=yes` is unreasonably popular it is desirable to encourage more specific shop tagging. Dropping `shop=yes` may encourage using some new shop values and in some cases people will mistakenly create new tags duplicating existing ones, but standard shop types are still encouraged by using icons. shop tag currently has long tail of unusual shop types (with most tagged correctly - for example `shop=maps`, some shop like this really exist), so data consumers need anyway some strategy for handling rare shop types. `shop=yes` is currenly reported as a tagging mistake by decent validators (for example JOSM and Osmose). Note that this is not deprecation of a tag but stopping to render a deprecated tag. This tag was never considered as a sufficient for tagging shop type --- project.mml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/project.mml b/project.mml index bb6f64daad..82f2f65810 100644 --- a/project.mml +++ b/project.mml @@ -1513,7 +1513,7 @@ Layer: 'amenity_' || CASE WHEN amenity IN ('vending_machine') AND tags->'vending' IN ('excrement_bags', 'parking_tickets', 'public_transport_tickets') THEN amenity ELSE NULL END, 'advertising_' || CASE WHEN tags->'advertising' in ('column') THEN tags->'advertising' else NULL END, 'emergency_' || CASE WHEN tags->'emergency' IN ('phone') AND way_area IS NULL THEN tags->'emergency' ELSE NULL END, - 'shop' || CASE WHEN shop IN ('no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE '' END, + 'shop' || CASE WHEN shop IN ('yes', 'no', 'vacant', 'closed', 'disused', 'empty') OR shop IS NULL THEN NULL ELSE '' END, 'leisure_' || CASE WHEN leisure IN ('amusement_arcade', 'beach_resort', 'bird_hide', 'bowling_alley', 'dog_park', 'firepit', 'fishing', 'fitness_centre', 'fitness_station', 'garden', 'golf_course', 'ice_rink', 'marina', 'miniature_golf', 'nature_reserve', 'outdoor_seating', 'park', 'picnic_table', 'pitch', 'playground', 'recreation_ground',