Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add settings context to add a tag for pagination #47

Merged
merged 4 commits into from
May 16, 2023

Conversation

VitaliiDC8
Copy link
Contributor

No description provided.

@VitaliiDC8 VitaliiDC8 requested a review from NikitaCG as a code owner May 15, 2023 19:16
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@VitaliiDC8 VitaliiDC8 changed the title Fix/add settings context to add a tag for pagination fix/add settings context to add a tag for pagination May 16, 2023
@VitaliiDC8 VitaliiDC8 changed the title fix/add settings context to add a tag for pagination fix:add settings context to add a tag for pagination May 16, 2023
@VitaliiDC8 VitaliiDC8 changed the title fix:add settings context to add a tag for pagination fix: add settings context to add a tag for pagination May 16, 2023
@@ -35,6 +38,7 @@ export const BlogConstructorProvider: React.FC<BlogConstructorProviderProps> = (
<RouterContext.Provider value={router} key="router-context" />,
<MobileContext.Provider value={Boolean(isMobile)} key="is-mobile-context" />,
<DeviceContext.Provider value={device} key="device-context" />,
<SettingsContext.Provider value={settings} key="settings-context" />,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add info about this context in context README

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</Button>
);

return (
<>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually use Fragment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator

@NikitaCG NikitaCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see in comments

@VitaliiDC8 VitaliiDC8 merged commit 0856675 into main May 16, 2023
@VitaliiDC8 VitaliiDC8 deleted the fix/add-settings-context-to-add-a-tag-for-pagination branch May 16, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants