fix: covering pagination buttons into 'a' tag #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
niktverd
requested changes
Apr 3, 2023
| className={b('item', mods)} | ||
| onClick={() => onClick?.(itemKey)} | ||
| loading={loading && Boolean(mods.active)} | ||
| <a |
There was a problem hiding this comment.
using an tag this way will reload an app every time we click on a paginator button. We need to be able eigther configure an tag we use or develop a way to prevent reloading
There was a problem hiding this comment.
it cannot be like this. we use event.preventDefault() on click an tag. App should be not reloaded
|
you need to rebase from main, because your branch have old dependencies, for example https://github.com/gravity-ui/blog-constructor/blob/fix/cover_pagination_into_a_tag/package.json#L82 |
…gravity-ui/blog-constructor into fix/cover_pagination_into_a_tag
niktverd
approved these changes
Apr 4, 2023
…gravity-ui/blog-constructor into fix/cover_pagination_into_a_tag
NikitaCG
reviewed
Apr 4, 2023
| @@ -33,6 +35,9 @@ export const Paginator = ({ | |||
| getPagesCount({itemsPerPage, totalItems, maxPages}), | |||
| ); | |||
|
|
|||
| const {locale} = useContext(LocaleContext); | |||
| const blogPath = getBlogPath(locale?.pathPrefix || ''); | |||
There was a problem hiding this comment.
Now the logic of creating an url is divided into two components. Maybe we should put this code in the Pagination Item ?
NikitaCG
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.